Skip to content

chore: Fix renovate.json#727

Merged
laurentsimon merged 1 commit intomainfrom
laurentsimon-patch-1
Jan 3, 2024
Merged

chore: Fix renovate.json#727
laurentsimon merged 1 commit intomainfrom
laurentsimon-patch-1

Conversation

@laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Dec 28, 2023

Should fix #726

Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
@laurentsimon laurentsimon changed the title Fix renovate.json chore: Fix renovate.json Dec 28, 2023
@laurentsimon laurentsimon enabled auto-merge (squash) January 3, 2024 17:31
@laurentsimon laurentsimon merged commit eecb791 into main Jan 3, 2024
ramonpetgrave64 pushed a commit to ramonpetgrave64/slsa-verifier that referenced this pull request Apr 10, 2024
Should fix slsa-framework#726

Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ramonpetgrave64 added a commit to slsa-framework/slsa-github-generator that referenced this pull request May 15, 2024
# Summary

Fixes renovate config to use the
[`config:best-practices`](https://docs.renovatebot.com/presets-config/#configbest-practices)
preset rather than the `config:base` preset since `config:base` seems to
have gone away at some point.

Also fixes the `schedule` config by using the
[`schedule:monthly`](https://docs.renovatebot.com/presets-schedule/#schedulemonthly)
preset. The previous `schedule` config seems to have been invalid
because "4 am" had space between "4" and "am" (this was fixed in the
`slsa-verifier` repo on
slsa-framework/slsa-verifier#727 but was never
fixed here).

Also adds a pre-submit to run the
[`renovate-config-validator`](https://docs.renovatebot.com/config-validation/)
to ensure that renovate config is valid. This pre-submit will need to be
made required in the repository branch protection rule for `main` in the
repository settings after this PR is merged.

Fixes #3634 #404 

## Testing Process

- Run `make renovate-config-validator` to check that the config is
valid.

## Checklist

- [x] Review the contributing
[guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md)
- [x] Add a reference to related issues in the PR description.
- [x] Update documentation if applicable.
- [x] Add unit tests if applicable.
- [x] Add changes to the
[CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md)
if applicable.

---------

Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Co-authored-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action Required: Fix Renovate Configuration

3 participants