Skip to content

fix: update pre-submit to ubuntu24#4080

Merged
ramonpetgrave64 merged 1 commit intomainfrom
ramonpetgrave64-patch-3
Jan 28, 2025
Merged

fix: update pre-submit to ubuntu24#4080
ramonpetgrave64 merged 1 commit intomainfrom
ramonpetgrave64-patch-3

Conversation

@ramonpetgrave64
Copy link
Contributor

Summary

Update pre-submit to use ubuntu24

https://github.com/slsa-framework/slsa-github-generator/actions/runs/12999310515/job/36254511524?pr=4041

Run ./.github/workflows/scripts/pre-submit.e2e.go.default.sh
✖ ubuntu24 == ubuntu22 :: .predicate.invocation.environment.os should be ubuntu22
Error: Process completed with exit code 1.

Testing Process

This PR's pre-submits should pass.

Checklist

  • Review the contributing guidelines
  • Add a reference to related issues in the PR description.
  • Update documentation if applicable.
  • Add unit tests if applicable.
  • Add changes to the CHANGELOG if applicable.

Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review January 27, 2025 23:14
@ramonpetgrave64
Copy link
Contributor Author

@loosebazooka

@ramonpetgrave64 ramonpetgrave64 merged commit be0c57c into main Jan 28, 2025
94 checks passed
ramonpetgrave64 added a commit that referenced this pull request Jan 28, 2025
# Summary

Update pre-submit to use ubuntu24

https://github.com/slsa-framework/slsa-github-generator/actions/runs/12999310515/job/36254511524?pr=4041

```
Run ./.github/workflows/scripts/pre-submit.e2e.go.default.sh
✖ ubuntu24 == ubuntu22 :: .predicate.invocation.environment.os should be ubuntu22
Error: Process completed with exit code 1.
```

## Testing Process

This PR's pre-submits should pass.

## Checklist

- [x] Review the contributing
[guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md)
- [x] Add a reference to related issues in the PR description.
- [ ] Update documentation if applicable.
- [x] Add unit tests if applicable.
- [ ] Add changes to the
[CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md)
if applicable.

Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
@ramonpetgrave64 ramonpetgrave64 deleted the ramonpetgrave64-patch-3 branch January 29, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants