revert: "feat: produce sigstore Bundles for generic generator and go builder workflows"#3985
Merged
ramonpetgrave64 merged 1 commit intomainfrom Oct 25, 2024
Conversation
…uilder w…" This reverts commit 2333f37.
Contributor
Author
|
@haydentherapper @loosebazooka |
loosebazooka
approved these changes
Oct 25, 2024
5 tasks
ramonpetgrave64
added a commit
that referenced
this pull request
Feb 12, 2025
# Summary Followup up to #3777, #3985, slsa-framework/slsa-verifier#813 Redo: Changes the internal go code to produce Sigstore Bundles, instead of only signed DSSE envelopes. This means that the generic generator and go builder workflows now produce Sigstore Bundles, just like the other BYOB-type workflows. ## Testing Process Tested with a previous commit that contains a debug workflow * https://github.com/slsa-framework/slsa-github-generator/actions/runs/13271183182 * main...internal-builder-bundle#diff-7e191d865f72ecdac3334e38bc0bd33c12349c6729a1702bc81765ecfcfb2c82 * generates provenances with `push` events * it uses a slightly modified version of slsa-verifier that respect provenances generated by non-main branches. * slsa-framework/slsa-verifier@main...sghg-go-bundle ## Checklist - [x] Review the contributing [guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md) - [x] Add a reference to related issues in the PR description. - [x] Update documentation if applicable. - [x] Add unit tests if applicable. - [x] Add changes to the [CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) if applicable. --------- Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3777
Lots of new failing errors in our e2e tests today. We may have missed something when testing these changes.
For now, we should revert while we debug, and come up with more robust testing methods.