#33: Deduplicate printer messages#57
Merged
alykhank merged 2 commits into40-java-portfrom Jun 27, 2015
Merged
Conversation
* Implement AutoCloseable in Printer, to use try-with-resources * Buffer and dedupe printer messages using a Set, flush on close() * Resolve TODOs referring to #33 (assertEquals in functional tests)
* Maintains invariant of flushing buffer even if close() is called again
Member
|
👍 |
alykhank
added a commit
that referenced
this pull request
Jun 27, 2015
#33: Deduplicate printer messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoCloseableinPrinter, to use try-with-resourcesSet, flush onclose()assertEqualsin functional tests)