Merged
Conversation
* UpperCamelCase name * blank name * lowerCamelCase name * snake_case name
tailor/sample.swift
Outdated
Member
There was a problem hiding this comment.
Can we rename this file to upperCamelCaseTests.swift or something along those lines? This file should only contain test cases for upper camel case checks. Then, you can put it into a folder where more swift test files can be added.
Member
Author
There was a problem hiding this comment.
Good idea, I'll name it UpperCamelCaseTests.swift and add it to a centralized test directory.
Move the test file into “functional_tests” directory
The file will contain the expected output for `UpperCamelCaseTests.swift` file.
Member
There was a problem hiding this comment.
How are you actually running this test?
Member
Author
There was a problem hiding this comment.
At the moment I pass in the file as an argument to the program and manually diff the output. In the near future (issue #20) a functional test harness will diff the generated output against the expected output.
* Multiple member values can appear on a single line, separated by commas
Remove duplication
Member
|
👍 |
Member
|
👍 |
adityatrivedi
added a commit
that referenced
this pull request
Jun 1, 2015
Resolve #8: Upper camel case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following constructs have checks for UpperCamelCase names:
Resolves #8.