Skip to content

#100: Close bracket style#143

Merged
adityatrivedi merged 15 commits intomasterfrom
at-100-close-bracket-style-6
Jul 29, 2015
Merged

#100: Close bracket style#143
adityatrivedi merged 15 commits intomasterfrom
at-100-close-bracket-style-6

Conversation

@adityatrivedi
Copy link
Copy Markdown
Member

Check close bracket styles for:

  • for loops
  • enum
  • closures

Resolves #100.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust this indent:

Location closeBraceLeftSiblingLocation =
    ListenerUtil.getParseTreeStopLocation(ParseTreeUtil.getLeftSibling(lastChild));

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add exceptions to this rule for enums with empty bodies ({}) but should also warn about empty bodies containing whitespace ({ }).

@alykhank
Copy link
Copy Markdown
Member

👍

@adityatrivedi adityatrivedi assigned a4sriniv and unassigned alykhank Jul 23, 2015
@a4sriniv
Copy link
Copy Markdown
Member

👍

1 similar comment
@alykhank
Copy link
Copy Markdown
Member

👍

adityatrivedi added a commit that referenced this pull request Jul 29, 2015
@adityatrivedi adityatrivedi merged commit 7cdd6a4 into master Jul 29, 2015
@adityatrivedi adityatrivedi deleted the at-100-close-bracket-style-6 branch July 29, 2015 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce bracket styles (Part 3)

3 participants