Add latch for ZK hydration initialization #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f52625 to
b33c13d
Compare
vthacker
reviewed
Aug 31, 2023
kaldb/src/main/java/com/slack/kaldb/metadata/core/KaldbMetadataStore.java
Show resolved
Hide resolved
vthacker
reviewed
Aug 31, 2023
kaldb/src/test/java/com/slack/kaldb/metadata/core/KaldbMetadataStoreTest.java
Show resolved
Hide resolved
vthacker
approved these changes
Aug 31, 2023
bryanlb
added a commit
that referenced
this pull request
Sep 1, 2023
bryanlb
added a commit
that referenced
this pull request
Sep 1, 2023
bryanlb
added a commit
that referenced
this pull request
Sep 5, 2023
bryanlb
added a commit
that referenced
this pull request
Sep 5, 2023
bryanlb
added a commit
that referenced
this pull request
Sep 5, 2023
* Revert "Revert "Add latch for ZK hydration initialization (#655)" (#664)" This reverts commit 451c305. * Change distributed query snapshot initialization Reduces churn due to ZK updates, separate executor to prevent potential deadlock --------- Co-authored-by: Bryan Burkholder <bryanlb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We currently do not block on cache initialization, which can cause downstream consumers to read incomplete/empty cache results. This now enforces the cache is completely hydrated before we allow any calls that rely on the cache to complete.
Resolves #651, closes #652