Conversation
zimeg
left a comment
There was a problem hiding this comment.
🍀 Leaving a few thoughts for the amazing readers and will set this to merge on approval with some confidence!
| package iostreams | ||
|
|
||
| // Prompt type definitions shared between survey and charm implementations. | ||
| // Prompts handle flag values and interactive forms for gathering user input. |
There was a problem hiding this comment.
🔭 note: This has the callout of prompts I'd like to make! I'm hoping we can improve how flags are parsed in prompts with the thinking that prompts have option for a flag value or form interactive input.
There was a problem hiding this comment.
This sounds like a healthy improvement opportunity for how we handle forms and flags. The first iteration has treated us well, but I agree that there is room for improvement!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 68.51% 68.54% +0.02%
==========================================
Files 218 218
Lines 18162 18162
==========================================
+ Hits 12444 12449 +5
+ Misses 4554 4551 -3
+ Partials 1164 1162 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Thanks for this improvement and thinking about the next evolution for our prompts - forms & flags! 📨 🎏
| package iostreams | ||
|
|
||
| // Prompt type definitions shared between survey and charm implementations. | ||
| // Prompts handle flag values and interactive forms for gathering user input. |
There was a problem hiding this comment.
This sounds like a healthy improvement opportunity for how we handle forms and flags. The first iteration has treated us well, but I agree that there is room for improvement!
|
|
||
| if io.config.WithExperimentOn(experiment.Huh) { | ||
| return charmPasswordPrompt(io, ctx, message, cfg) | ||
| return passwordForm(io, ctx, message, cfg) |
|
@mwbrooks Of course! These are nice iterations to have for ongoing changes I hope... Thanks again for such kind thoughts and fast review 🚢 💨 |
Changelog
Summary
This PR moves the
huhimplementations to aniostreams/formspackage with hopes of having prompts as the input method for a flag or interactive form 📚Reviewers
No change to functionalities! But I remain curious to thoughts on changes of the package 🎁
Requirements