Fix #893 Add support for admin.barriers.* API methods#942
Merged
seratch merged 1 commit intoslackapi:mainfrom Feb 2, 2021
Merged
Fix #893 Add support for admin.barriers.* API methods#942seratch merged 1 commit intoslackapi:mainfrom
seratch merged 1 commit intoslackapi:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #942 +/- ##
==========================================
- Coverage 86.08% 86.07% -0.02%
==========================================
Files 57 57
Lines 4995 5018 +23
==========================================
+ Hits 4300 4319 +19
- Misses 695 699 +4
Continue to review full report at Codecov.
|
misscoded
approved these changes
Feb 2, 2021
| "admin.conversations.whitelist.add", # deprecated | ||
| "admin.conversations.whitelist.listGroupsLinkedToChannel", # deprecated | ||
| "admin.conversations.whitelist.remove", # deprecated | ||
| "admin.conversations.getCustomRetention", |
Contributor
There was a problem hiding this comment.
What is the connection between these additions and the admin.barriers.* methods?
Contributor
Author
There was a problem hiding this comment.
After our last update on the public endpoint list here, these are also added. However, we (specifically I) are still unable to support them for a reason. Thus, I've added them to the skip list.
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #893 by adding supports for admin.barriers.* endpoints.
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./docs.sh?)/docs-src-v2(Documents, have you run./docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python setup.py validateafter making the changes.