[#830] Clarify channel type in docs for Running the App#831
Merged
seratch merged 1 commit intoslackapi:mainfrom Oct 5, 2020
Merged
[#830] Clarify channel type in docs for Running the App#831seratch merged 1 commit intoslackapi:mainfrom
seratch merged 1 commit intoslackapi:mainfrom
Conversation
In issue slackapi#830, a developer tried to DM the bot and didn't receive a response because the 'message.im' event was not used. This tutorial only uses 'message.channels', so the bot must be invited to a public channel to receive the "start" message. This commit clarifies that the bot must be invited to a public channel.
Codecov Report
@@ Coverage Diff @@
## main #831 +/- ##
=======================================
Coverage 87.29% 87.29%
=======================================
Files 30 30
Lines 3761 3761
Branches 337 337
=======================================
Hits 3283 3283
Misses 329 329
Partials 149 149 Continue to review full report at Codecov.
|
seratch
approved these changes
Oct 5, 2020
Contributor
|
@mwbrooks Thanks for improving this! LGTM. Can you make the same PR for the |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In issue #830, a developer tried to DM the bot and didn't
receive a response because the 'message.im' event was not used.
This tutorial only uses 'message.channels', so the bot must be
invited to a public channel to receive the "start" message.
This commit clarifies that the bot must be invited to a public channel.
Category (place an
xin each of the[ ])Requirements (place an
xin each[ ])python setup.py validateafter making the changes.