Skip to content

Add include_categories to emoji.list args#1317

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:include_categories
Jan 11, 2023
Merged

Add include_categories to emoji.list args#1317
seratch merged 1 commit intoslackapi:mainfrom
seratch:include_categories

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Jan 11, 2023

Summary

This pull request adds a new argument to emoji.list API. Refer to slackapi/java-slack-sdk#821 (comment) for its context.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Jan 11, 2023
@seratch seratch added this to the 3.20.0 milestone Jan 11, 2023
@seratch seratch self-assigned this Jan 11, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 11, 2023

Codecov Report

Merging #1317 (0f4aedd) into main (9217bcb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
+ Coverage   85.40%   85.41%   +0.01%     
==========================================
  Files         111      111              
  Lines       11334    11337       +3     
==========================================
+ Hits         9680     9684       +4     
+ Misses       1654     1653       -1     
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 82.39% <100.00%> (+0.01%) ⬆️
slack_sdk/web/client.py 83.69% <100.00%> (+0.01%) ⬆️
slack_sdk/web/legacy_client.py 83.42% <100.00%> (+0.01%) ⬆️
slack_sdk/socket_mode/builtin/internals.py 72.53% <0.00%> (+0.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit 6e5d8b0 into slackapi:main Jan 11, 2023
@seratch seratch deleted the include_categories branch January 11, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality Version: 3x web-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants