Fix #1297 Building user_auth_blocks with slack_sdk.models class objects for chat.unfurl API call fails#1301
Merged
seratch merged 1 commit intoslackapi:mainfrom Nov 16, 2022
Conversation
…ts for chat.unfurl API call fails
Codecov Report
@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
- Coverage 85.79% 85.78% -0.02%
==========================================
Files 84 84
Lines 7845 7846 +1
==========================================
Hits 6731 6731
- Misses 1114 1115 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
filmaj
approved these changes
Nov 15, 2022
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves #1297
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.