Skip to content

Add message metadata support#1207

Merged
seratch merged 2 commits intoslackapi:mainfrom
seratch:message-metadata
May 3, 2022
Merged

Add message metadata support#1207
seratch merged 2 commits intoslackapi:mainfrom
seratch:message-metadata

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented May 3, 2022

Summary

This pull request adds message metadata support: https://api.slack.com/metadata

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels May 3, 2022
@seratch seratch added this to the 3.15.3 milestone May 3, 2022
@seratch seratch requested review from filmaj and srajiang May 3, 2022 05:47
@seratch seratch self-assigned this May 3, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented May 3, 2022 •
edited
Loading

Codecov Report

Merging #1207 (ac069b1) into main (9fb0df9) will increase coverage by 0.03%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
+ Coverage   86.51%   86.55%   +0.03%     
==========================================
  Files         110      111       +1     
  Lines       10872    10893      +21     
==========================================
+ Hits         9406     9428      +22     
+ Misses       1466     1465       -1
Impacted Files Coverage Δ
slack_sdk/models/metadata/__init__.py 83.33% <83.33%> (ø)
slack_sdk/web/async_client.py 85.10% <100.00%> (+0.01%) ⬆️
slack_sdk/web/client.py 86.48% <100.00%> (+0.01%) ⬆️
slack_sdk/web/internal_utils.py 94.53% <100.00%> (+0.26%) ⬆️
slack_sdk/web/legacy_client.py 86.20% <100.00%> (+0.01%) ⬆️
slack_sdk/socket_mode/builtin/internals.py 72.36% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb0df9...ac069b1. Read the comment docs.

filmaj
filmaj approved these changes May 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seratch @filmaj
Update slack_sdk/models/metadata/__init__.py
ac069b1 
Co-authored-by: Fil Maj <maj.fil@gmail.com>
srajiang
srajiang approved these changes May 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@seratch seratch merged commit 268d7eb into slackapi:main May 3, 2022
@seratch seratch deleted the message-metadata branch May 3, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@filmaj filmaj filmaj approved these changes

@srajiang srajiang srajiang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality Version: 3x web-client

Projects

None yet

Milestone

3.16.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seratch @filmaj @srajiang