Add admin.users.unsupportedVersions.export API support#1174
Merged
seratch merged 2 commits intoslackapi:mainfrom Feb 10, 2022
Merged
Add admin.users.unsupportedVersions.export API support#1174seratch merged 2 commits intoslackapi:mainfrom
seratch merged 2 commits intoslackapi:mainfrom
Conversation
seratch
commented
Feb 9, 2022
| def admin_users_unsupportedVersions_export( | ||
| self, | ||
| *, | ||
| date_end_of_support: Optional[Union[str, int]] = None, |
Contributor
Author
There was a problem hiding this comment.
The value should be an integer but, as with other methods in this SDK, both int and str should be accepted here.
Codecov Report
@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
+ Coverage 86.62% 86.63% +0.01%
==========================================
Files 110 110
Lines 10780 10789 +9
==========================================
+ Hits 9338 9347 +9
Misses 1442 1442
Continue to review full report at Codecov.
|
srajiang
approved these changes
Feb 10, 2022
Contributor
Author
|
@srajiang Thanks for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds admin.users.unsupportedVersions.export API method to the Web API client.
The endpoint always returns ok: true or ok: false + error only. After that, the org admin user who performed the API will receive a DM from Slackbot.
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.