Skip to content

Fix WebClient#files_upload does not send channels since v3.10.0#1106

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:files-upload-bug
Aug 26, 2021
Merged

Fix WebClient#files_upload does not send channels since v3.10.0#1106
seratch merged 1 commit intoslackapi:mainfrom
seratch:files-upload-bug

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Aug 26, 2021

Summary

This pull request fixes a regression bug by #1099

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels Aug 26, 2021
@seratch seratch added this to the 3.10.1 milestone Aug 26, 2021
@seratch seratch self-assigned this Aug 26, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1106 (acf58bd) into main (550ee24) will decrease coverage by 0.06%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
- Coverage   86.29%   86.23%   -0.07%     
==========================================
  Files         110      110              
  Lines       10413    10416       +3     
==========================================
- Hits         8986     8982       -4     
- Misses       1427     1434       +7
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 91.97% <72.72%> (-0.10%) ⬇️
slack_sdk/web/client.py 93.21% <72.72%> (-0.21%) ⬇️
slack_sdk/web/legacy_client.py 93.01% <72.72%> (-0.10%) ⬇️
slack_sdk/socket_mode/builtin/client.py 79.19% <0.00%> (-0.68%) ⬇️
slack_sdk/socket_mode/builtin/connection.py 35.71% <0.00%> (-0.43%) ⬇️
slack_sdk/web/base_client.py 88.53% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 550ee24...acf58bd. Read the comment docs.

@seratch seratch merged commit 19d5052 into slackapi:main Aug 26, 2021
@seratch seratch deleted the files-upload-bug branch August 26, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@seratch seratch

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client

Projects

None yet

Milestone

3.10.1

Development

Successfully merging this pull request may close these issues.

1 participant

@seratch