Improve #1084 by removing globally mutable lists#1092
Merged
seratch merged 1 commit intoslackapi:mainfrom Aug 13, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1092 +/- ##
==========================================
+ Coverage 86.17% 86.19% +0.02%
==========================================
Files 110 110
Lines 9928 9932 +4
==========================================
+ Hits 8555 8561 +6
+ Misses 1373 1371 -2
Continue to review full report at Codecov.
|
seratch
added a commit
to seratch/python-slack-sdk
that referenced
this pull request
Aug 13, 2021
16 tasks
seratch
added a commit
that referenced
this pull request
Aug 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request removes all the globally mutable list objects from the pull request #1084 changes. If we have those, mutating the list of retry handlers can cause side effects to other API client instances in the same app.
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./docs.sh?)/docs-src-v2(Documents, have you run./docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.