Skip to content

Add new args to admin.users.list and update web API response types#1688

Merged
filmaj merged 1 commit intoslackapi:mainfrom
seratch:admin_users_list
Nov 2, 2023
Merged

Add new args to admin.users.list and update web API response types#1688
filmaj merged 1 commit intoslackapi:mainfrom
seratch:admin_users_list

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Nov 2, 2023

Summary

This pull request adds two newly added options to https://api.slack.com/methods/admin.users.list

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` labels Nov 2, 2023
@seratch seratch added this to the web-api@7.0 milestone Nov 2, 2023
@seratch seratch self-assigned this Nov 2, 2023
@seratch
Copy link
Contributor Author

seratch commented Nov 2, 2023

@filmaj Do you have ETA for #1673? If it can take long (that's totally fine!), we may want to cherry-pick this change and cut a new release in 6.x series.

@seratch seratch requested a review from filmaj November 2, 2023 05:45
@filmaj
Copy link
Contributor

filmaj commented Nov 2, 2023

@seratch yes I believe it will take longer. I can merge this into a 6.x maintenance branch and release.

@filmaj
Copy link
Contributor

filmaj commented Nov 2, 2023

@seratch I have created a web-api-6.x branch based off the branch that we released 6.9.1. Can you change the target of this PR to that branch, please?

@filmaj
Copy link
Contributor

filmaj commented Nov 2, 2023

Please ignore my last comment! I will merge this into main and cherry-pick into web-api-6.x myself.

@filmaj filmaj merged commit f1d3be3 into slackapi:main Nov 2, 2023
@filmaj filmaj modified the milestones: web-api@7.0, web-api@6.10 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants