Skip to content

Update the Web API response types (incl. token rotation fields)#1285

Merged
misscoded merged 1 commit intoslackapi:feat-token-rotationfrom
seratch:feat-token-rotation-response-types
Jul 13, 2021
Merged

Update the Web API response types (incl. token rotation fields)#1285
misscoded merged 1 commit intoslackapi:feat-token-rotationfrom
seratch:feat-token-rotation-response-types

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Jul 13, 2021

Summary

This pull request updates the Web API response types. Many changes are duplicated to this pull request #1284 but merging this pull request to this branch won't cause git conflicts.

We can use the updated types in the OAuth package.

Requirements (place an x in each [ ])

@seratch seratch added the pkg:web-api applies to `@slack/web-api` label Jul 13, 2021
@seratch seratch added this to the web-api@6.3 milestone Jul 13, 2021
@seratch seratch requested a review from misscoded July 13, 2021 09:37
@seratch
Copy link
Copy Markdown
Contributor Author

seratch commented Jul 13, 2021

This is related to #1244

@seratch
Copy link
Copy Markdown
Contributor Author

seratch commented Jul 13, 2021

It seems that the target branch has lint errors.

> @slack/oauth@2.1.0-tokenRotationBeta.1 lint
> tslint --project .


ERROR: /home/runner/work/node-slack-sdk/node-slack-sdk/packages/oauth/src/index.ts:206:56 - Expected parentheses around arrow function argument.
ERROR: /home/runner/work/node-slack-sdk/node-slack-sdk/packages/oauth/src/index.ts:212:16 - Expected parentheses around arrow function argument.

@misscoded
Copy link
Copy Markdown
Contributor

misscoded commented Jul 13, 2021

It seems that the target branch has lint errors.

I'm not seeing these errors when I run the command locally but will fix and revisit why that might be.

@misscoded misscoded merged commit 48a2a06 into slackapi:feat-token-rotation Jul 13, 2021
@seratch seratch deleted the feat-token-rotation-response-types branch July 14, 2021 03:25
misscoded pushed a commit that referenced this pull request Jul 14, 2021
@seratch @misscoded
Update the Web API response types (incl. token rotation fields) (#1285)
ba5f932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@misscoded misscoded misscoded approved these changes

Assignees

No one assigned

Labels

pkg:web-api applies to `@slack/web-api`

Projects

None yet

Milestone

web-api@6.3

Development

Successfully merging this pull request may close these issues.

2 participants

@seratch @misscoded