Merged
Conversation
seratch
commented
May 1, 2021
| public abstract apiCall(method: string, options?: WebAPICallOptions): Promise<WebAPICallResult>; | ||
|
|
||
| public readonly admin = { | ||
| // TODO: admin.analytics.getFile |
Contributor
Author
There was a problem hiding this comment.
As described at #1191 , this endpoint returns binary data. We will work on it separately.
packages/web-api/src/methods.ts
Outdated
| list: | ||
| bindApiCall<AdminAppsRestrictedListArguments, AdminAppsRestrictedListResponse>(this, 'admin.apps.restricted.list'), | ||
| }, | ||
| // TODO: Use AdminAppsUninstallResponse when it's available |
Contributor
Author
There was a problem hiding this comment.
AdminAppsUninstallResponse will be available once we merge slackapi/java-slack-sdk#735
| }, | ||
| }; | ||
|
|
||
| public readonly channels = { |
Contributor
Author
There was a problem hiding this comment.
Moved these to the bottom - see also https://api.slack.com/changelog/2020-01-deprecating-antecedents-to-the-conversations-api
| }, | ||
| }; | ||
|
|
||
| public readonly views = { |
Contributor
Author
There was a problem hiding this comment.
Moved this one to make the list here alphabetical order
| is_pending_ext_shared?: boolean; | ||
| connected_team_ids?: string[]; | ||
| conversation_host_id?: string; | ||
| channel_email_addresses?: string[]; |
Contributor
Author
There was a problem hiding this comment.
Ran ./scripts/generate-web-api-types.sh
stevengill
approved these changes
May 6, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the following API methods to
WebClient.Also, I moved the non-conversation API methods to the bottom as they no longer work (we may want to delete them in the near future but we won't do so in v6.2).
Requirements (place an
xin each[ ])