Skip to content

Add admin.apps.uninstall API support#735

Merged
seratch merged 2 commits intoslackapi:mainfrom
seratch:admin.apps.uninstall
May 5, 2021
Merged

Add admin.apps.uninstall API support#735
seratch merged 2 commits intoslackapi:mainfrom
seratch:admin.apps.uninstall

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Apr 30, 2021

This pull request adds admin.apps.uninstall API support. The endpoint is available only for Enterprise Grid organizations.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client labels Apr 30, 2021
@seratch seratch added this to the 1.8.0 milestone Apr 30, 2021
@seratch seratch self-assigned this Apr 30, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2021

Codecov Report

Merging #735 (8401bb6) into main (2aacf7d) will increase coverage by 0.02%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #735      +/-   ##
============================================
+ Coverage     77.26%   77.28%   +0.02%     
- Complexity     3278     3283       +5     
============================================
  Files           368      368              
  Lines          9711     9721      +10     
  Branches        927      928       +1     
============================================
+ Hits           7503     7513      +10     
  Misses         1658     1658              
  Partials        550      550
Impacted Files Coverage Δ Complexity Δ
.../java/com/slack/api/methods/MethodsRateLimits.java 98.44% <ø> (ø) 9.00 <0.00> (ø)
...java/com/slack/api/methods/RequestFormBuilder.java 89.52% <83.33%> (-0.03%) 278.00 <1.00> (+1.00) ⬇️
...slack/api/methods/impl/AsyncMethodsClientImpl.java 94.07% <100.00%> (+0.03%) 356.00 <2.00> (+2.00)
.../com/slack/api/methods/impl/MethodsClientImpl.java 85.02% <100.00%> (+0.04%) 492.00 <2.00> (+2.00)
...i/socket_mode/impl/SocketModeClientJavaWSImpl.java 61.90% <0.00%> (+0.68%) 32.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aacf7d...8401bb6. Read the comment docs.

@seratch seratch mentioned this pull request May 1, 2021
Merged
2 tasks
@seratch seratch merged commit 9d449c0 into slackapi:main May 5, 2021
@seratch seratch deleted the admin.apps.uninstall branch May 5, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

1 participant

@seratch