server unsafe code audit: fixed memory leaks and other violations #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple fixes were applied: - Memory leak in `FixedVec` due to zero length free - Possible unsoundess in use of moved boxed slice pointers - Fixed user-after-free (UAF) in ordered idx impl I'm further working on finding and fixing other sources of safety violations; even though they may not be "major" but we must steer clear of them (such as miri SB violations).
Also note that we now properly classify tests based on leak severity for the generic audit routine.
Due to the amount of single core burn miri needs, it is almost impractical to run it on every commit with our currently allocated CI resources. We may revisit this in the future.
Member
Author
|
This is good to go; fully tested locally (impossible to run on CI). @glydr r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bunch of memory leaks (mostly very low impact since a majority of them only happen at startup time and don't change throughout) and some possible violations resulting from
noaliasoptimizations (rustc -> generated LLVM IR) for unique pointers in std.Unsafe code audit for Q2 2024 stands complete.
✔️ By submitting this pull request, I agree to the CLA at: https://cla.skytable.io/skytable/skytable