fix(gui): make the Split view checkbox correctly toggle between both modes#2801
Merged
skylot merged 1 commit intoskylot:masterfrom Feb 24, 2026
Merged
fix(gui): make the Split view checkbox correctly toggle between both modes#2801skylot merged 1 commit intoskylot:masterfrom
skylot merged 1 commit intoskylot:masterfrom
Conversation
skylot
approved these changes
Feb 24, 2026
Owner
Collaborator
Author
|
@skylot Just tested it and it was even more broken without that PR. |
skylot
pushed a commit
that referenced
this pull request
Feb 24, 2026
skylot
pushed a commit
that referenced
this pull request
Feb 24, 2026
Owner
@jpstotz 🤣 I backport this PR (into new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed minor bug: The new "Split view" checkbox works for like a three-state button. When switching from split to normal the checkbox often stays checked.
The problem seems to be that the Split view checkbox not only exists once but multiple times, one persistent instance for the normal view and one instance that is every time created when you switch to the split view mode.
IMHO the code is with my changes is still very complex and a bit "mind-twisted" but now the checkbox state is consistent.
While playing around with the split view I got the feeling that when you activate split view the smali code pane (and the smali code) is loaded multiple times I think up to five times. Also the code position jumps around a few times (beginning -> code pos -> beginning -> code pos) which is not very nice. But I wasn't able to identify the cause for this.