fix: back to the old correct resource ID calculation#2788
Merged
skylot merged 1 commit intoskylot:masterfrom Feb 12, 2026
Merged
fix: back to the old correct resource ID calculation#2788skylot merged 1 commit intoskylot:masterfrom
skylot merged 1 commit intoskylot:masterfrom
Conversation
skylot
approved these changes
Feb 12, 2026
Owner
|
Hm, looks like we need to add an integration test for this 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts some of the changes introduced by #2777 regarding the resource ID calculation.
As described in #2786 the resource ID is important for constant replacement.
This PR also includes changes regarding the protection system to protect us against duplicate resource entry and the renaming cascade and memory problem as described in #2775, it now bases on the index, not on the offset.
fixes #2786