Skip to content

Prevent problems arising by parsing duplicate resource entries from resources.arsc#2777

Merged
skylot merged 4 commits intoskylot:masterfrom
jpstotz:resNameColl
Feb 7, 2026
Merged

Prevent problems arising by parsing duplicate resource entries from resources.arsc#2777
skylot merged 4 commits intoskylot:masterfrom
jpstotz:resNameColl

Conversation

@jpstotz
Copy link
Copy Markdown
Collaborator

@jpstotz jpstotz commented Feb 7, 2026

fixes #2775

  • redefines the ResourceEntry.id as offset in the arsc file
  • introduces a check to prevent creating the same ResourceEntry multiple times
  • in case we somehow still get identical resource ids make sure not to generate resource names that are getting longer and longer by every rename

skylot
skylot approved these changes Feb 7, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@skylot skylot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you 👍

@skylot skylot merged commit 925503b into skylot:master Feb 7, 2026
2 checks passed
@jpstotz jpstotz deleted the resNameColl branch February 9, 2026 18:25
@jpstotz jpstotz mentioned this pull request Feb 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skylot skylot skylot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[core] Jadx fails to decompile resources (OutOfMemoryError)

2 participants

@jpstotz @skylot