Fix Type inference error: updates count limit reached#2629
Merged
skylot merged 2 commits intoskylot:masterfrom Sep 9, 2025
Merged
Fix Type inference error: updates count limit reached#2629skylot merged 2 commits intoskylot:masterfrom
skylot merged 2 commits intoskylot:masterfrom
Conversation
* Fix for the "Type inference error: updates count limit reached" * Users will be able to choose the limit and possibly avoid this error * Adding options on decompilation settings
Updating README.md with new type update limit parameter
Owner
|
@Away-pp thanks, but this PR looks like not a fix but a workaround. Anyway, your PR is good. But next time, please use a different branch (not master) as your PR source, this allows me to apply small fixes directly in PR. |
skylot
approved these changes
Sep 9, 2025
skylot
added a commit
that referenced
this pull request
Sep 9, 2025
Contributor
Author
|
Hi @skylot . I agree with you, this is indeed a workaround and not a proper fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for the '"Type inference error: updates count limit reached" found on #2585
I did not test with the method passed because only the failed method was provided (not sure how to test in this case).
However, I have tested with the following code https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/content/pm/PackageParser.java#4028
Without modifying type update limit parameter
With modifying
Anyway, I believe the issue presented on #2585 was that there was no proper way of setting the type update limit variable, so I am putting as fixed.
Fixes #2585