fix(gui): created dynamic theme for code editor#2471
Conversation
|
@MrIkso look awesome, thanks 👍 Although, the option name is a little confusing, because it is unclear what it does. Also, this should be an entry in editor themes combo box, I will check if this can be done. As for naming: something like |
|
@MrIkso I commit changes to put your dynamic theme in an editor theme combo box. I adjust code so it will be easier to add new themes and also simplify exposing an API for changing editor themes in plugins in the future. Also, I slightly change your code to use identifiers (most of the text in the code) color from UI theme, this might break some of your intentions, so please check it. And I think we should use less hardcoded colors and use directly or mix more colors from UI theme, this way it will appear much better in my option. |
|
@skylot nice. I forgot to add default color for annotations in dark theme, add it |
This PR add new theme for code editor based on current app theme and dynamic update if theme changed. Maybe fixed #1763, #1735
Preview: Googe Drive
jadx_editor_theme_720p.mp4