fix: desktop app no longer silently exits on missing kubeconfig#400
Merged
nadaverell merged 1 commit intomainfrom Apr 1, 2026
Merged
fix: desktop app no longer silently exits on missing kubeconfig#400nadaverell merged 1 commit intomainfrom
nadaverell merged 1 commit intomainfrom
Conversation
GUI apps don't inherit shell environment variables like KUBECONFIG, so users with non-default kubeconfig paths saw a silent exit when launching from Finder/desktop. Three changes: - enrichEnv() now captures KUBECONFIG and cloud provider env vars from the login shell (not just PATH) - InitializeK8s failure shows a "No Cluster Configuration" error in the UI instead of calling log.Fatalf - Frontend gets a dedicated "config" error type with actionable hints
7e43b16 to
6c46239
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #383. The desktop app silently exited when launched from Finder/Launchpad if the user's kubeconfig wasn't at
~/.kube/config. GUI apps don't inherit shell environment variables likeKUBECONFIG, so users who set it in.zshrc/.bashrcsaw the app vanish without any error.Three changes:
enrichEnv()replacesenrichPath()— now capturesKUBECONFIG,AWS_PROFILE,GOOGLE_APPLICATION_CREDENTIALS, and other cloud provider env vars from the user's login shell, not justPATHInitializeK8serrors are shown in the UI as a "No Cluster Configuration" screen with actionable hints, instead of callinglog.Fatalfwhich silently kills the processconfigerror type in frontend — dedicated error view explaining how to setKUBECONFIGor pass--kubeconfigThe app now always starts the UI regardless of kubeconfig state, matching user expectations for a desktop application.