Update header table constraints#58
Merged
elizabethengelman merged 1 commit intostagingfrom Feb 27, 2020
Merged
Conversation
removing the block hash from the constraint
gslaughl
approved these changes
Feb 25, 2020
gslaughl
left a comment
There was a problem hiding this comment.
LGTM! My only question is whether we want to do anything on conflict, since right now it looks like InternalInsertHeader doesn't do anything if it runs into a conflict. Could that result in us discarding the correct header, and keeping the bad header in a reorg?
gslaughl
reviewed
Feb 26, 2020
| created TIMESTAMP NOT NULL DEFAULT NOW(), | ||
| updated TIMESTAMP NOT NULL DEFAULT NOW(), | ||
| UNIQUE (block_number, hash, eth_node_id) | ||
| UNIQUE (block_number, eth_node_id) |
There was a problem hiding this comment.
Sounds like my concern about potentially discarding the canonical header is misplaced, since if that happens it'll get fixed when the header is validated 👍
yaoandrew
approved these changes
Feb 27, 2020
| err error | ||
| timestamp string | ||
| db *postgres.DB | ||
| db = test_config.NewTestDB(test_config.NewTestNode()) |
|
|
||
| _, err = repo.InternalInsertHeader(headerTwo) | ||
| Expect(err).To(HaveOccurred()) | ||
| Expect(err).To(MatchError(repositories.ErrValidHeaderExists)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing the block hash from the constraint