1189 add addresses to storage initializers#124
Merged
elizabethengelman merged 5 commits intostagingfrom Feb 17, 2020
Merged
Conversation
64a531b to
34103c5
Compare
rmulhol
approved these changes
Feb 13, 2020
| var catAddress = constants.GetContractAddress("MCD_CAT") | ||
| var StorageTransformerInitializer transformer.StorageTransformerInitializer = storage.Transformer{ | ||
| Address: common.HexToAddress(constants.GetContractAddress("MCD_CAT")), | ||
| HashedAddress: types.HexToKeccak256Hash(constants.GetContractAddress("MCD_CAT")), |
Contributor
There was a problem hiding this comment.
Not really a big deal but I'm wondering if we might want to only inject the Address and then make HashedAddress private/derive it from the Address. I think it'd be hard to make this mistake but it'd be a bummer if we accidentally passed in different constants to HexToAddress vs HexToKeccak256Hash
Contributor
Author
There was a problem hiding this comment.
Yep, I really like that idea! I'll make that change in this PR and in sky-ecosystem/vulcanizedb#38
go.mod
Outdated
| github.com/makerdao/vulcanizedb v0.0.12-rc.1.0.20200212223442-9582deb86491 | ||
| github.com/mattn/go-runewidth v0.0.6 | ||
| github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | ||
| github.com/modern-go/reflect2 v1.0.1 // indirect |
Contributor
There was a problem hiding this comment.
I've noticed these two deps seeming to move in and out of the go.mod 🤔
Contributor
Author
There was a problem hiding this comment.
good call. i may leave them out of this PR the until we can get to the bottom of if this change is necessary/what we want
elizabethengelman
pushed a commit
that referenced
this pull request
Feb 28, 2020
* Bump vDB version to 0.0.12-rc.1 * Fix alias for historical flop states * VDB-1189: Add addresses to storage initializers (#124) * Update vdb version to include Address in storage initializers * Add contract addresses to storage initializers * Remove HashedAddress in favor of Address in storage initializers * (VDB-1164) Copy over migrations from vDB * 1189 update transformer imports (#126) * Update vdb version to include Address in storage initializers * Update storage transformer imports * Update transformerExporter.go to reflect new location of storage transformer interface * Update event transformer imports * Update transformerExporter.go to reflect new location of event transformer interface * Update vdb version to include new location for transformer interfaces * (VDB-1199) Add extractDiffs to docker-compose.yml - Also remove unnecessary env data from other images * Vdb 1200 get storage value dockerfile (#127) * Add Dockerfile for getStorageValue cmd * Move execute dockerfiles to their own directory * TO-879: dockerhub via travis (#120) * dockerhub via travis * Update travis/deploy.sh to account for new path to execute dockerfile * Build and push get-storage-value docker image in travis/deploy.sh * (VDB-1207) Remove non-essential smart comments (#131) * (VDB-1207) Add smart tags to document DB - Currently exposed tables and queries in all schemas * Remove unused code * Omit queries that perform mutations * Expose and document storage tables * Remove smart tags from migrations - Except cases where they omit a mutation - Moving them over to postgraphile.tags.json5 for easier updating * Remove an unused smart comment Co-authored-by: Elizabeth <emengelman@gmail.com> * Update postgres version in travis build (#132) * Update postgres version in travis build to 11.6 this is the most recent posgres version available in RDS at the moment * updates travis secrets (#133) * Update vdb to v0.0.13-rc.1 (#134) * Makes updates to dockerfile/README.md * Copy header migration change from vdb (#136) * (VDB-1202) OSM change event transformer * Update vdb version to v0.0.13-rc.2 (#138) Co-authored-by: Rob Mulholand <rmulholand@8thlight.com> Co-authored-by: Gabe Laughlin <gabe@bistrotech.net> Co-authored-by: daimesava <56128157+daimesava@users.noreply.github.com> Co-authored-by: Andrew J Yao <1547809+yaoandrew@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
companion vdb PR: sky-ecosystem/vulcanizedb#38