Skip to content

[ENH] Move SimpleRNNClassifier test skip config to tags#9559

Merged
fkiraly merged 3 commits intosktime:mainfrom
Spandan-Mishra:tests_config-SimpleRNNClassifier
Mar 12, 2026
Merged

[ENH] Move SimpleRNNClassifier test skip config to tags#9559
fkiraly merged 3 commits intosktime:mainfrom
Spandan-Mishra:tests_config-SimpleRNNClassifier

Conversation

@Spandan-Mishra
Copy link
Copy Markdown
Contributor

@Spandan-Mishra Spandan-Mishra commented Mar 5, 2026

Reference Issues/PRs

Fixes #8515

What does this implement/fix? Explain your changes.

  • Removed SimpleRNNClassifier from EXCLUDED_TESTS in sktime/tests/_config.py
  • Added tests:skip_by_name to SimpleRNNClassifier alongwith the corresponding skipped tests

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

This fix is a part of #8515 and involves moving of the skipped test for SimpleRNNClassifier from tests/_config.py to the estimator tags

Did you add any tests for the change?

No

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
  • Optionally, for added estimators: I've added myself and possibly to the maintainers tag - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

fkiraly
fkiraly previously approved these changes Mar 12, 2026
Copy link
Copy Markdown
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@fkiraly fkiraly merged commit 4b79bdb into sktime:main Mar 12, 2026
1 check was pending
Faakhir30 pushed a commit to Faakhir30/sktime that referenced this pull request Mar 13, 2026
#### Reference Issues/PRs
Fixes sktime#8515 

#### What does this implement/fix? Explain your changes.

- Removed SimpleRNNClassifier from EXCLUDED_TESTS in
sktime/tests/_config.py
- Added tests:skip_by_name to SimpleRNNClassifier alongwith the
corresponding skipped tests

#### What should a reviewer concentrate their feedback on?

This fix is a part of sktime#8515 and involves moving of the skipped test for
SimpleRNNClassifier from tests/_config.py to the estimator tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] move test skip config from tests._config to estimator tags

2 participants