[ENH] Move SimpleRNNClassifier test skip config to tags#9559
Merged
fkiraly merged 3 commits intosktime:mainfrom Mar 12, 2026
Merged
[ENH] Move SimpleRNNClassifier test skip config to tags#9559fkiraly merged 3 commits intosktime:mainfrom
fkiraly merged 3 commits intosktime:mainfrom
Conversation
Faakhir30
pushed a commit
to Faakhir30/sktime
that referenced
this pull request
Mar 13, 2026
#### Reference Issues/PRs Fixes sktime#8515 #### What does this implement/fix? Explain your changes. - Removed SimpleRNNClassifier from EXCLUDED_TESTS in sktime/tests/_config.py - Added tests:skip_by_name to SimpleRNNClassifier alongwith the corresponding skipped tests #### What should a reviewer concentrate their feedback on? This fix is a part of sktime#8515 and involves moving of the skipped test for SimpleRNNClassifier from tests/_config.py to the estimator tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #8515
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
This fix is a part of #8515 and involves moving of the skipped test for SimpleRNNClassifier from tests/_config.py to the estimator tags
Did you add any tests for the change?
No
Any other comments?
PR checklist
For all contributions
maintainerstag - do this if you want to become the owner or maintainer of an estimator you added.See here for further details on the algorithm maintainer role.
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.