Fix use of seasonal periodicity in naive model with mean strategy#917
Closed
Flix6x wants to merge 4 commits intosktime:mainfrom
Closed
Fix use of seasonal periodicity in naive model with mean strategy#917Flix6x wants to merge 4 commits intosktime:mainfrom
Flix6x wants to merge 4 commits intosktime:mainfrom
Conversation
Contributor
|
With the recently introduced docstring tests, you need to fix all docstrings the files you touched. You can use |
# Conflicts: # .all-contributorsrc
Contributor
Author
|
I merged your main branch into this branch, which fixes the docstrings. Is this what you intended? |
Contributor
|
@fkiraly could I ask you to review this one? I think it's fine but would be good to have someone else look over the unit test. |
Contributor
|
Closed in favour of #1124 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #907
What does this implement/fix? Explain your changes.
Prepend rather than append NaN values in case of seasonal periodicity not fitting an integer number of times in the window length.
Does your contribution introduce a new dependency? If yes, which one?
No new dependencies.
What should a reviewer concentrate their feedback on?
The added test, and how it fits in with other tests.
Any other comments?
No.
PR checklist
For all contributions
For new estimators