Fix use of seasonal periodicity in naive model with mean strategy (from PR #917)#1124
Merged
Fix use of seasonal periodicity in naive model with mean strategy (from PR #917)#1124
Conversation
Collaborator
|
FYI, @Flix6x, since we're currently preparing the new release version: we branched off your PR and took care of the merge issues. Thanks a lot for the fix! |
Contributor
Author
|
Thanks @Flix6x now merged! |
Contributor
|
Great! FYI, I had been stalling my work on #918 until this was merged, because I believe it requires similar logic to handle cases with seasonal periodicity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #907
Supersedes #917