[ENH] add _transform_score template and remove dead fmt related code from detectors#7425
Merged
fkiraly merged 13 commits intosktime:mainfrom Nov 24, 2024
Merged
Conversation
…res as an abstract method.
ShivamSingal
commented
Nov 22, 2024
fkiraly
previously approved these changes
Nov 22, 2024
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
Looks good - pure dead code removal, thanks!
_transform_score template and remove dead fmt related code from detectors
6cd4f52 to
d7e2060
Compare
200f126 to
d3e6e2d
Compare
ShivamSingal
commented
Nov 23, 2024
ShivamSingal
commented
Nov 24, 2024
Collaborator
|
@ShivamJ07 , thanks a lot for your work! Some advice:
|
fkiraly
approved these changes
Nov 24, 2024
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
I am merging now - looks good.
We should keep PR small.
benHeid
pushed a commit
that referenced
this pull request
Feb 15, 2025
…ode from detectors (#7425) Please see #7388 for more details. - This PR is part of the effort to remove references to the `_fmt` attribute in child detectors, following its deprecation in #6265. - The _fmt attribute was deprecated and hardcoded to sparse, making it non-configurable by users. Therefore, removing branching logic based on _fmt does not introduce regression, since methods like `predict_scores` already defaulted to sparse output which was expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…res as an abstract method.
Reference Issues/PRs
Please see #7388 for more details.
What does this implement/fix? Explain your changes.
WIP (only addressed clasp, will address pyOD in future commits)
_fmtattribute in child detectors, following its deprecation in [ENH] Rework of base series annotator API #6265.predict_scoresalready defaulted to sparse output which was expected.For all contributions
How to: add yourself to the all-contributors file in the
sktimeroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference