[ENH] refactor datatypes example fixtures to BaseObject classes#7133
Merged
[ENH] refactor datatypes example fixtures to BaseObject classes#7133
datatypes example fixtures to BaseObject classes#7133Conversation
Collaborator
Author
|
Note for reviewers: the refactor was AI-assisted, and I spotted a few examples where the The tests check consistency and whether the correct tags are detected, so the refactor should be tested against the checkers, which have not changed. |
benHeid
pushed a commit
that referenced
this pull request
Feb 15, 2025
…7133) Refactors the example fixtures in the `datatypes` module along the lines of sktime/skpro#458: * a base class for datatype examples, `BaseExample`, to replace the more ad-hoc dictionary design * a complete refactor of all `_example` submodules to this interface * a full refactor of the public framework module with `get_example` logic, in `datatypes`, to allow extensibility with this design Beyond the refactor, sets the `polars` requirements for the `polars` data examples to `polars>=1.0`, and adds `pyarrow` as a requirement, consistent with the status quo in `skpro`. Closes #7128, as it addresses the issue both from an isolation perspective, as well as the missing argument perspective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the example fixtures in the
datatypesmodule along the lines of sktime/skpro#458:BaseExample, to replace the more ad-hoc dictionary design_examplesubmodules to this interfaceget_examplelogic, indatatypes, to allow extensibility with this designBeyond the refactor, sets the
polarsrequirements for thepolarsdata examples topolars>=1.0, and addspyarrowas a requirement, consistent with the status quo inskpro.Closes #7128, as it addresses the issue both from an isolation perspective, as well as the missing argument perspective.