[ENH] second param sets for selected estimators#3428
Merged
Conversation
This was referenced Sep 14, 2022
fkiraly
added a commit
that referenced
this pull request
Aug 12, 2023
In order to test parameter settings for estimators properly, each important parameter should have been set to a non-default. This PR introduces a test which checks that there are at least two test parameter sets (if the estimator has at least one parameter), and correctness of these sets. Requires: * #4279 for the general test for `get_test_params` (no specific number assumed) * #2835 as it uses the parameter name interface * #3428 to pass the `no-softdeps` step. Current estimators are not tested due to differential testing. If diff testing is turned off, helps tracking down the estimators that do not yet have two parameter sets, see #3429.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3429. This adds a second parameter set for all estimators checked via
check_estimatorin theno-softdepsCI element.This is generally useful, and also allows #2862 to pass that CI element.
... and we already discovered a bug, which I suppose proves that #3429 is generally a good idea.
The bug is
ExponentTransformer.inverse_transformbreaking ifpoweris close to zero. This is now dealt with by a skip and a warning.