Skip to content

Forecasting tutorial rework - with cell content#1037

Merged
fkiraly merged 37 commits intomainfrom
forecasting-tutorial-rework
Jun 24, 2021
Merged

Forecasting tutorial rework - with cell content#1037
fkiraly merged 37 commits intomainfrom
forecasting-tutorial-rework

Conversation

@fkiraly
Copy link
Copy Markdown
Collaborator

@fkiraly fkiraly commented Jun 23, 2021

This is the forecasting tutorial with all cell contents, see #972.

No other changes except cell content in the main forecasting tutorial added.

@fkiraly fkiraly requested a review from mloning as a code owner June 23, 2021 20:43
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fkiraly fkiraly requested a review from aiwalter June 23, 2021 20:44
Copy link
Copy Markdown
Contributor

@mloning mloning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the setup instructions at the top? As said, this should go somewhere else, either an automatically generated header in the docs or simply a link to the install instructions.

@fkiraly
Copy link
Copy Markdown
Collaborator Author

fkiraly commented Jun 24, 2021

Can we remove the setup instructions at the top? As said, this should go somewhere else, either an automatically generated header in the docs or simply a link to the install instructions.

Sure - do we already have any of that? If yes, please provide link

Merging to get the "big bit" out of the way (figures) once the tests pass, we can always work on individual changes to bits and pieces in separate PR.

@fkiraly fkiraly merged commit 19e86b8 into main Jun 24, 2021
@fkiraly fkiraly deleted the forecasting-tutorial-rework branch June 24, 2021 22:54
fkiraly added a commit that referenced this pull request Jun 24, 2021
fkiraly added a commit that referenced this pull request Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants