Skip to content

[ENH] enable default for predict in probabilistic regressors if only interval predictions are possible#65

Merged
fkiraly merged 2 commits into
mainfrom
fix-base-predict-defaulting
Sep 9, 2023
Merged

[ENH] enable default for predict in probabilistic regressors if only interval predictions are possible#65
fkiraly merged 2 commits into
mainfrom
fix-base-predict-defaulting

Conversation

@fkiraly

@fkiraly fkiraly commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

This adds a default for predict if only interval/quantile predictions are possible, but not full distribution predictions.

@codecov-commenter

codecov-commenter commented Sep 9, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (0d8bd68) 70.91% compared to head (77f2104) 70.95%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   70.91%   70.95%   +0.03%     
==========================================
  Files          93       93              
  Lines        4962     4964       +2     
  Branches      900      899       -1     
==========================================
+ Hits         3519     3522       +3     
  Misses       1205     1205              
+ Partials      238      237       -1     
Files Changed Coverage Δ
skpro/regression/base/_base.py 65.40% <100.00%> (+1.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly merged commit 9ab47a5 into main Sep 9, 2023
fkiraly pushed a commit that referenced this pull request Sep 13, 2023
Adds bagging ensemble of probabilistic regressors.

Complete rewrite of the legacy estimator.

Depends on:
* #26 for the mixture distribution
used in bagging.
* #65 for the default of `predict`,
if `_predict_proba` or other proba methods are implemented but not
`_predict`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement module:regression probabilistic regression module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants