Bugfix: Status bar does not update when the appearance changes on Android#50
Bugfix: Status bar does not update when the appearance changes on Android#50marcprux merged 3 commits intoskiptools:mainfrom
Conversation
|
Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @fhasse95 on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file |
|
@cla-bot check |
|
recheck |
|
This will be a great improvement! Unfortunately, it isn't working for me. Was there anything else that needs to be done to get it working (like a change to Screen.Recording.2025-12-13.at.16.29.33.mov |
|
Hi @marcprux, I’ve now made a few additional adjustments so that it works correctly in both cases. |
|
It works great, thanks! We will also update the default app template (created with |
Currently, when the system appearance changes from light to dark mode (or vice versa) on Android, the status bar icons do not update accordingly. As a result, the status bar icons and text may have insufficient contrast (e.g., light icons on a light background or vice versa). This happens because the system bar style is not re-applied when the appearance changes.
Steps to Reproduce:
=> The status bar icons keep their previous appearance and do not adapt to the new system theme ⚡
This PR solves the issue by re-applying the system bar style when the system appearance changes, ensuring that the status bar icons always match the current light / dark mode.
Thank you for developing Skip! 😊
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Skip Pull Request Checklist:
swift test