Skip to content

Inconsistency between the date entry format and the display format#151

Merged
tarekio merged 30 commits intomainfrom
BYNT-655-Inconsistency-between-the-date-entry-format-and-the-display-formatt
Aug 22, 2025
Merged

Inconsistency between the date entry format and the display format#151
tarekio merged 30 commits intomainfrom
BYNT-655-Inconsistency-between-the-date-entry-format-and-the-display-formatt

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Aug 6, 2025

Jira Issue

  1. BYNT-655

Description

Dates are entered to events and other date fields using the US format mm/dd/yyyy, but they are always displayed using ISO date format yyyy-mm-dd. The formula should be standardized.

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@apodacaduron apodacaduron requested a review from tarekio August 6, 2025 22:12
@apodacaduron apodacaduron self-assigned this Aug 6, 2025
Copy link
Contributor

@tarekio tarekio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's standarize to use ISO (DD/MM/YYYY) everywhere. This will be good for the purposes of this PR. In the future, we'll add a setting in system setting to allow admins to choose a standard.

@tarekio tarekio requested a review from level09 August 8, 2025 12:49
…d-the-display-formatt' of https://github.com/sjacorg/bayanat into BYNT-655-Inconsistency-between-the-date-entry-format-and-the-display-formatt
…55-Inconsistency-between-the-date-entry-format-and-the-display-formatt
@apodacaduron
Copy link
Contributor Author

@tarekio Updated to DD/MM/YYYY, and sounds good should be an easy update 👍🏻

Copy link
Contributor

@tarekio tarekio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still more fields to cover:

Image Image

These are in Bulletins, Actors, events, system settings revision.

@apodacaduron
Copy link
Contributor Author

@tarekio updated

@apodacaduron apodacaduron requested a review from tarekio August 19, 2025 18:46
…55-Inconsistency-between-the-date-entry-format-and-the-display-formatt
…55-Inconsistency-between-the-date-entry-format-and-the-display-formatt
Copy link
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@tarekio tarekio merged commit cc75414 into main Aug 22, 2025
7 checks passed
@tarekio tarekio deleted the BYNT-655-Inconsistency-between-the-date-entry-format-and-the-display-formatt branch August 22, 2025 22:08
tarekio pushed a commit that referenced this pull request Sep 6, 2025
There was a typo on the formatDate function, the keyword `this.` was missing, this bug was introduced in the recent PR #151.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants