Merged
Conversation
tarekio
approved these changes
Jul 17, 2025
level09
requested changes
Jul 18, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
Found some bugs in tests and small issue in endpoint.
Let's also change put mapping tests. (rename correctly to test_put_mapping etc ..) and let's use create_mapping instead of get_first_or_fail , I think it is always better to use the create fixture rather than relying on existing test db data.
…ssues. rename 'map' variable to prevent shadowing built-in type
…#135) ## Jira Issue 1. [BYNT-1392](https://syriajustice.atlassian.net/browse/BYNT-1392) ## Description implement delete endpoint on sheet mappings ## Checklist - [ ] Tests added/updated - [ ] Documentation updated (if needed) - [ ] New strings prepared for translations ## API Changes (if applicable) - [ ] Permissions checked - [ ] Endpoint tests added ## Additional Notes [Any other relevant information] [BYNT-1391]: https://syriajustice.atlassian.net/browse/BYNT-1391?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [BYNT-1392]: https://syriajustice.atlassian.net/browse/BYNT-1392?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: tarekio <7659394+tarekio@users.noreply.github.com>
level09
approved these changes
Jul 31, 2025
…391-delete-mapping-endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
Add DELETE /mapping/int:id route for Admins.
Only the specific Admin user who is associated with the mapping can delete it
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]