implement delete mapping endpoint and optimistic update mappings list#135
Merged
tarekio merged 5 commits intobynt-1391-delete-mapping-endpointfrom Jul 18, 2025
Merged
Conversation
tarekio
approved these changes
Jul 17, 2025
level09
reviewed
Jul 18, 2025
| this.resetFields(); | ||
| this.selectedMap = null; | ||
| this.mapid = null | ||
| }).catch(err => { |
Collaborator
There was a problem hiding this comment.
This is nice, but with optimistic UI approach, we have to roll back if we encounter a backend error , maybe something like
deleteMap() {
if (!confirm("{{ _('Are you sure you want to delete this mapping?')}}")) return;
const originalMaps = [...this.maps]; // Backup
const mapIndex = this.maps.findIndex(map => map.id === this.mapid);
// Optimistic update
this.maps = this.maps.filter(map => map.id !== this.mapid);
this.resetFields();
axios.delete(`/import/api/mapping/${this.mapid}`)
.then(res => {
this.showSnack(res.data);
}).catch(err => {
// Revert on error
this.maps = originalMaps;
this.showSnack('Delete failed');
console.log(err.response);
});
}
level09
approved these changes
Jul 18, 2025
…ment-delete-mapping
d26f00e
into
bynt-1391-delete-mapping-endpoint
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
implement delete endpoint on sheet mappings
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]