fix(skills): use registry-backed search for skills discovery#929
Merged
xiaket merged 2 commits intosipeed:mainfrom Mar 1, 2026
Merged
fix(skills): use registry-backed search for skills discovery#929xiaket merged 2 commits intosipeed:mainfrom
xiaket merged 2 commits intosipeed:mainfrom
Conversation
Signed-off-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com>
xiaket
reviewed
Mar 1, 2026
xiaket
reviewed
Mar 1, 2026
xiaket
reviewed
Mar 1, 2026
xiaket
requested changes
Mar 1, 2026
Collaborator
xiaket
left a comment
There was a problem hiding this comment.
Please take a look and let me know when it's ready.
Signed-off-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com>
Contributor
Author
|
Addressed all requested changes in c0c7964, replied to each thread, and resolved all three review threads. Ready for re-review. Thanks! |
vvr3ddy
added a commit
to vvr3ddy/picoclaw
that referenced
this pull request
Mar 1, 2026
Changes from upstream: - fix(channel): config cleanup and regex precompile (sipeed#911, sipeed#916) - fix(github_copilot): improve error handling (sipeed#919) - fix(wecom): context leaks and data race fixes (sipeed#914, sipeed#918) - fix(tools): HTTP client caching and response body cleanup (sipeed#940) - feat(tui): Add configurable Launcher and Gateway process management (sipeed#909) - feat(migrate): Update migration system with openclaw support (sipeed#910) - fix(skills): Use registry-backed search for skills discovery (sipeed#929) - build: Add armv6 support to goreleaser (sipeed#905) - docs: Sync READMEs and channel documentation
Contributor
|
@dwizzle204 Switching skills search from the stale hardcoded index to the registry system is the right call. Having search aligned with how skills are actually managed avoids those confusing 404s. We're putting together the PicoClaw Dev Group on Discord for contributors to collaborate. If you'd like to join, send an email to |
liangzhang-keepmoving
pushed a commit
to liangzhang-keepmoving/picoclaw
that referenced
this pull request
Mar 2, 2026
) * fix(skills): use registry-backed search for skills discovery Signed-off-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com> * fix(skills): address review comments for registry search Signed-off-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com> --------- Signed-off-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com> Co-authored-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com>
hyperwd
pushed a commit
to hyperwd/picoclaw
that referenced
this pull request
Mar 5, 2026
) * fix(skills): use registry-backed search for skills discovery Signed-off-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com> * fix(skills): address review comments for registry search Signed-off-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com> --------- Signed-off-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com> Co-authored-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com>
Pluckypan
pushed a commit
to Pluckypan/picoclaw
that referenced
this pull request
Mar 6, 2026
) * fix(skills): use registry-backed search for skills discovery Signed-off-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com> * fix(skills): address review comments for registry search Signed-off-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com> --------- Signed-off-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com> Co-authored-by: dwizzle204 <25712917+dwizzle204@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fixes
skills searchreturning 404 by removing the stale hardcoded skills index lookup and using configured skill registries (ClawHub) for discovery.This keeps search aligned with the registry system already used elsewhere in skills workflows.
🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
Fixes #928
📚 Technical Context (Skip for Docs)
skills searchcurrently calls a hardcoded URL (https://raw.githubusercontent.com/sipeed/picoclaw-skills/main/skills.json) that returns 404.RegistryManager,ClawHubRegistry) and should be the source of truth.skills searchto registry-backed search and preserves existing error prefix (Failed to fetch skills list) for CLI consistency.🧪 Test Environment
📸 Evidence (Optional)
Click to view Logs/Screenshots
Local verification:
go generate ./...✅make check✅☑️ Checklist