Skip to content

Prompt to modify the max_tool_iterations parameter.#855

Merged
lxowalle merged 3 commits intosipeed:mainfrom
lxowalle:fix/prompt_to_modify_max_tool_iterations
Feb 27, 2026
Merged

Prompt to modify the max_tool_iterations parameter.#855
lxowalle merged 3 commits intosipeed:mainfrom
lxowalle:fix/prompt_to_modify_max_tool_iterations

Conversation

@lxowalle
Copy link
Collaborator

@lxowalle lxowalle commented Feb 27, 2026 •
edited
Loading

📝 Description

  • When the user encounters "I've completed processing but have no response to give," prompt them to modify max_tool_iterations.
  • Set default value of max_tool_iterations to 50

🗣️ Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📖 Documentation update
  • ⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

  • 🤖 Fully AI-generated (100% AI, 0% Human)
  • 🛠️ Mostly AI-generated (AI draft, Human verified/modified)
  • 👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

☑️ Checklist

  • My code/docs follow the style of this project.
  • I have performed a self-review of my own changes.
  • I have updated the documentation accordingly.

@lxowalle lxowalle requested a review from alexhoshina February 27, 2026 07:25
alexhoshina
alexhoshina approved these changes Feb 27, 2026
View reviewed changes
Copy link
Collaborator

@alexhoshina alexhoshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lxowalle lxowalle merged commit b6927c9 into sipeed:main Feb 27, 2026
2 checks passed
@Huaaudio
Copy link
Collaborator

Huaaudio commented Feb 27, 2026

Just a reminder that there is another default value in pkg/agent/instance.go:

	if maxIter == 0 {
		maxIter = 20
	}

But I'd like to also propose a solution wrt #440

liangzhang-keepmoving pushed a commit to liangzhang-keepmoving/picoclaw that referenced this pull request Mar 2, 2026
@lxowalle @liangzhang-keepmoving
Prompt to modify the max_tool_iterations parameter. (sipeed#855)
4187b84 
* Prompt to modify the max_tool_iterations parameter.

* fix typo and set max iterations to 50
hyperwd pushed a commit to hyperwd/picoclaw that referenced this pull request Mar 5, 2026
@lxowalle
Prompt to modify the max_tool_iterations parameter. (sipeed#855)
45a4c43 
* Prompt to modify the max_tool_iterations parameter.

* fix typo and set max iterations to 50
Pluckypan pushed a commit to Pluckypan/picoclaw that referenced this pull request Mar 6, 2026
@lxowalle
Prompt to modify the max_tool_iterations parameter. (sipeed#855)
8a3327c 
* Prompt to modify the max_tool_iterations parameter.

* fix typo and set max iterations to 50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexhoshina alexhoshina alexhoshina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lxowalle @Huaaudio @alexhoshina