Skip to content

fix: resolve fallback model alias parsing for issue #783#824

Merged
yinwm merged 3 commits intosipeed:mainfrom
0xYiliu:fix/issue-783-fallback-alias-resolution
Feb 27, 2026
Merged

fix: resolve fallback model alias parsing for issue #783#824
yinwm merged 3 commits intosipeed:mainfrom
0xYiliu:fix/issue-783-fallback-alias-resolution

Conversation

@0xYiliu
Copy link
Contributor

@0xYiliu 0xYiliu commented Feb 26, 2026

Summary

  • resolve fallback candidates with a lookup-aware path so model_name aliases are mapped via model_list before provider/model parsing
  • update agent candidate construction to resolve aliases from model_list, including nested OpenRouter model paths and no-protocol aliases
  • add regression tests for alias resolution, deduplication, and default-provider behavior; add execution document for issue [BUG] Model list entries with / in model field cause provider resolution failure #783

Verification

  • make check
  • go test ./pkg/agent ./pkg/providers -run 'ResolveCandidatesFromModelListAlias|ResolveCandidatesWithLookup_AliasResolvesToNestedModel|ResolveCandidatesWithLookup_DeduplicateAfterLookup|ResolveCandidatesWithLookup_AliasWithoutProtocolUsesDefaultProvider'

Fixes #783

AI Disclosure Reminder

  • Please disclose the AI-generated code level in the PR description according to CONTRIBUTING.zh.md.

@0xYiliu 0xYiliu mentioned this pull request Feb 26, 2026
Closed
yinwm
yinwm approved these changes Feb 27, 2026
View reviewed changes
Copy link
Collaborator

@yinwm yinwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yinwm yinwm merged commit 70fcbc5 into sipeed:main Feb 27, 2026
2 checks passed
@yinwm
Copy link
Collaborator

yinwm commented Feb 27, 2026

thanks for the pr

@nikolasdehor nikolasdehor mentioned this pull request Feb 28, 2026
Open
hyperwd pushed a commit to hyperwd/picoclaw that referenced this pull request Mar 5, 2026
@yinwm
Merge pull request sipeed#824 from 0xYiliu/fix/issue-783-fallback-ali…
35d1a3f 
…as-resolution

fix: resolve fallback model alias parsing for issue sipeed#783
Pluckypan pushed a commit to Pluckypan/picoclaw that referenced this pull request Mar 6, 2026
@yinwm
Merge pull request sipeed#824 from 0xYiliu/fix/issue-783-fallback-ali…
6327d54 
…as-resolution

fix: resolve fallback model alias parsing for issue sipeed#783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yinwm yinwm yinwm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Model list entries with / in model field cause provider resolution failure

2 participants

@0xYiliu @yinwm