Skip to content

Fix: missing Tavily config in loop.go, invalid web_search param#660

Merged
lxowalle merged 1 commit intosipeed:mainfrom
ulolol:fix/tavily_config
Feb 23, 2026
Merged

Fix: missing Tavily config in loop.go, invalid web_search param#660
lxowalle merged 1 commit intosipeed:mainfrom
ulolol:fix/tavily_config

Conversation

@ulolol
Copy link
Contributor

@ulolol ulolol commented Feb 23, 2026

📝 Description

This PR adds the missing config and reverts the invalid web_search param changed during testing

🗣️ Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📖 Documentation update
  • ⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

  • 🤖 Fully AI-generated (100% AI, 0% Human)
  • 🛠️ Mostly AI-generated (AI draft, Human verified/modified)
  • 👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

🔗 Related Issue

Fixes #654

📚 Technical Context (Skip for Docs)

  • Reference URL:
  • Reasoning:

🧪 Test Environment

  • Hardware: AMD64
  • OS: ArchLinux
  • Model/Provider:
  • Channels: CLI

📸 Evidence (Optional)

Click to view Logs/Screenshots image image

☑️ Checklist

  • My code/docs follow the style of this project.
  • I have performed a self-review of my own changes.
  • I have updated the documentation accordingly.

@ulolol
Copy link
Contributor Author

ulolol commented Feb 23, 2026

Adds the missing config and reverts the invalid param I had set during testing.

Tested and added screens in Evidence

I missed adding all the commit from my test branch when raising the last PR.
Apologies, and sorry for increasing your workload...
Please review and merge @lxowalle

Copy link

@nikolasdehor nikolasdehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two straightforward fixes:

  1. Tavily config fields were missing from the tool registration in loop.go, meaning the Tavily API key and settings were never wired through. Good catch.

  2. "include_raw_content": "false" was sending a JSON string "false" instead of the boolean false. The Tavily API likely rejected or misinterpreted it.

LGTM.

@lxowalle
Copy link
Collaborator

Thank you for the timely fix.@ulolol

@lxowalle lxowalle merged commit 4cc8b90 into sipeed:main Feb 23, 2026
2 checks passed
@ulolol
Copy link
Contributor Author

ulolol commented Feb 23, 2026

Apologies once again, and thanks for merging!

@ulolol ulolol deleted the fix/tavily_config branch February 23, 2026 04:41
@Orgmar
Copy link
Contributor

Orgmar commented Feb 24, 2026

@ulolol Thanks for plugging the missing Tavily config in loop.go and reverting the invalid web_search param. Without that config entry users would hit confusing errors trying to use Tavily search.

We have the PicoClaw Dev Group on Discord for contributors to connect and collaborate. If you're interested, send an email to support@sipeed.com with the subject [Join PicoClaw Dev Group] ulolol and we'll send the invite!

liangzhang-keepmoving pushed a commit to liangzhang-keepmoving/picoclaw that referenced this pull request Mar 2, 2026
hyperwd pushed a commit to hyperwd/picoclaw that referenced this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tavily web_search tool fails with "Invalid value for include_raw_content"

6 participants