fix(heartbeat): resolve bug where service could never start#64
Merged
lxowalle merged 1 commit intosipeed:mainfrom Feb 12, 2026
Merged
Conversation
HeartbeatService.Start() always returned early because running() checked stopChan closure state, which is "open" (= true) for a newly created service. This caused Start() to interpret a fresh service as "already running" and skip launching the goroutine. Introduce a `started` bool field to separate "has been started" from "has not been stopped", fixing both the start failure and a potential double-close panic on Stop().
Collaborator
|
Thanks for the pr! |
emadomedher
pushed a commit
to emadomedher/picoclaw
that referenced
this pull request
Feb 17, 2026
…ce-start-bug fix(heartbeat): resolve bug where service could never start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
running()checks whetherstopChanis closed, but a newly created service has an open channel, sorunning()always returnedtrue, causingStart()to exit early thinking it was already running.started boolfield to separate "has been started" from "has not been stopped", which also prevents a potential double-close panic whenStop()is called more than once.startedstopChanfalseStart()proceeds, launches goroutinetrueStart()is idempotent (no-op)falseStop()is idempotent,runLoopexitsTest plan
go build ./...passesgo vet ./pkg/heartbeat/...passesStart()(enable heartbeat in config, observe periodic heartbeat logs)Stop()is safe to call multiple times without panic