Conversation
nikolasdehor
left a comment
There was a problem hiding this comment.
Large formatting PR from running golangci-lint fmt with gci, gofmt, gofumpt, goimports, and golines enabled. The changes include:
-
CI workflow cleanup — Removes the standalone fmt-check job since the linter now handles formatting. The vet and test jobs no longer depend on fmt-check. This is correct.
-
Makefile improvements — Adds a lint target and changes fmt to use golangci-lint fmt instead of go fmt. Good.
-
Formatting changes — The bulk of the diff is mechanical formatting: import grouping (gci), octal literals (0644 -> 0o644 via gofumpt), line wrapping (golines), map[string]interface{} -> map[string]any, blank line removal, etc. These are all standard formatter outputs.
-
No functional changes — I spot-checked several files and all changes are cosmetic. The map[string]interface{} to map[string]any changes are a Go 1.18+ alias and are semantically identical.
One concern: this is a 90-file, 2200-line diff that will conflict with essentially every other open PR. Merging this first and having other PR authors rebase is the cleanest path, but it will create friction. Consider coordinating with maintainers on merge timing.
LGTM on the content.
# Conflicts: # pkg/agent/loop.go # pkg/agent/loop_test.go # pkg/channels/discord.go # pkg/channels/onebot.go # pkg/config/config.go # pkg/tools/subagent_tool_test.go
# Conflicts: # cmd/picoclaw/main.go # pkg/agent/context.go # pkg/agent/loop.go # pkg/channels/dingtalk.go # pkg/channels/feishu_64.go # pkg/channels/line.go # pkg/channels/manager.go # pkg/config/config.go # pkg/migrate/migrate_test.go # pkg/providers/anthropic/provider_test.go # pkg/providers/claude_provider_test.go # pkg/providers/http_provider.go # pkg/providers/openai_compat/provider.go # pkg/providers/protocoltypes/types.go # pkg/providers/types.go
harshbansal7
left a comment
There was a problem hiding this comment.
Not to forget, need to raise a PR to remove redundant linters.
feat(fmt): Run formatters
📝 Description
This PR is just a result of running
golangci-lint fmt, also old fmt check from CI is removed since linter already will check that.🗣️ Type of Change
🤖 AI Code Generation
📸 Evidence (Optional)
Click to view Logs/Screenshots
☑️ Checklist