Merged
Conversation
lukemilby
approved these changes
Feb 17, 2026
Contributor
lukemilby
left a comment
There was a problem hiding this comment.
Looks good to me. Nothing extra and clean
nikolasdehor
left a comment
There was a problem hiding this comment.
Good work adding Cerebras support — the documentation across all three README locales is thorough, and the JA README bonus provider table is a nice touch.
However, this PR targets pkg/providers/http_provider.go which has since been refactored upstream. The CreateProvider() function and model prefix stripping now live in pkg/providers/factory.go. This PR needs a rebase against current main.
Specifically, you'll need to:
- Add
case "cerebras":in the explicit provider switch (~line 77 infactory.go) - Add the boolean case for model-name detection in the fallback switch (~line 216)
- Add prefix stripping for
"cerebras/"in the model normalization code
The config struct and documentation changes should merge cleanly. Once rebased, this is ready to approve.
3 tasks
hyperwd
pushed a commit
to hyperwd/picoclaw
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added misssing provider section in README.ja.md