fix(agent): use atomic.Bool for AgentLoop.running to prevent data race#30
Merged
yinwm merged 1 commit intosipeed:mainfrom Feb 12, 2026
Merged
Conversation
Run() and Stop() access the `running` field from different goroutines without synchronization. Replace the bare `bool` with `sync/atomic.Bool` to eliminate the data race.
Collaborator
|
thanks for pr |
Contributor
|
Thanks for your contribution! We are forming the PicoClaw Dev Group to accelerate the evolution of the project. Any developer with more than one merged PR is invited to join. Would you like to join the PicoClaw Dev Group? If so, please send an email to |
emadomedher
pushed a commit
to emadomedher/picoclaw
that referenced
this pull request
Feb 17, 2026
fix(agent): use atomic.Bool for AgentLoop.running to prevent data race
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boolwithsync/atomic.Boolfor theAgentLoop.runningfieldProblem
Run()readsrunningin a loop on one goroutine, whileStop()writes it from another. Without synchronization this is a data race per the Go memory model.Changes
running boolrunning atomic.Boolal.running = trueal.running.Store(true)for al.running {for al.running.Load() {al.running = falseal.running.Store(false)1 file changed, 5 insertions(+), 5 deletions(-)
Test plan
go build ./...passesgo vet ./...passesgo test ./...passes