Remove duplicate truncate functions, reuse utils.Truncate#29
Merged
yinwm merged 1 commit intosipeed:mainfrom Feb 12, 2026
Merged
Remove duplicate truncate functions, reuse utils.Truncate#29yinwm merged 1 commit intosipeed:mainfrom
yinwm merged 1 commit intosipeed:mainfrom
Conversation
Multiple packages had their own private truncate implementations: - channels/telegram.go: truncateString (byte-based, no "...") - channels/dingtalk.go: truncateStringDingTalk (byte-based, no "...") - voice/transcriber.go: truncateText (byte-based, with "...") All three are functionally equivalent to the existing utils.Truncate, which already handles rune-safe truncation and appends "..." correctly. Replace all private copies with utils.Truncate and delete the dead code.
Collaborator
|
Thanks for the PR! |
emadomedher
pushed a commit
to emadomedher/picoclaw
that referenced
this pull request
Feb 17, 2026
…ncate Remove duplicate truncate functions, reuse utils.Truncate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utils.TruncatetruncateString,truncateStringDingTalk,truncateText) were byte-based and could corrupt multi-byte UTF-8 characters;utils.Truncateis rune-safeDetails
channels/telegram.gotruncateStringchannels/dingtalk.gotruncateStringDingTalkvoice/transcriber.gotruncateTextAll call sites now use
utils.Truncatewhich already exists and handles Unicode correctly.Test plan
go build ./...passesgo vet ./...passesgo test ./...passes (all existing tests green)